Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Thanos store time portioning ; extraEnv for all deployments #950

Merged
merged 17 commits into from
Oct 19, 2019

Conversation

levydori
Copy link
Contributor

@levydori levydori commented Oct 15, 2019

Q A
Bug fix? yes
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License Apache 2.0

What's in this PR?

  • Adding support for store time portioning in the Thanos chart. Time portioning is a Thanos feature (https://thanos.io/components/store.md/#time-based-partioning) added to Thanos version 0.7.0 and higher
  • Adding option to add extraEnv for all deployment (It was actually a bug - as the readme showed it can be added to store, but there was no way of doing it

Why?

On a large bucket, the store component requires a lot of memory to run, and may take a lot of time to start. Breaking stores to smaller partitions reduces the resources used per Pod.

Additional context

https://thanos.io/components/store.md/#time-based-partioning

Checklist

  • User guide and development docs updated (if needed) - Chart readme update
  • Related Helm chart(s) updated (if needed)

To Do

Copy link
Contributor

@tarokkk tarokkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks promising :) thank you. I had one question/comment regarding the example.

@levydori
Copy link
Contributor Author

@tarokkk Thanks for the comments - fixed.

@levydori levydori changed the title Support for Thanos store time portioning Support for Thanos store time portioning ; extraEnv for all deployments Oct 16, 2019
@tarokkk tarokkk merged commit 8f68462 into banzaicloud:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants