Skip to content

Commit

Permalink
Updated naming in deferred work queue. (iree-org#18230)
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Woloszyn <andrew.woloszyn@gmail.com>
  • Loading branch information
AWoloszyn authored Aug 15, 2024
1 parent 3fdfb33 commit b6602e8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion runtime/src/iree/hal/drivers/cuda/cuda_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ static iree_status_t iree_hal_cuda_device_queue_execute(
iree_hal_cuda_device_t* device = iree_hal_cuda_device_cast(base_device);
IREE_TRACE_ZONE_BEGIN(z0);

iree_status_t status = iree_hal_deferred_work_queue_enque(
iree_status_t status = iree_hal_deferred_work_queue_enqueue(
device->work_queue, iree_hal_cuda_device_collect_tracing_context,
device->tracing_context, wait_semaphore_list, signal_semaphore_list,
command_buffer_count, command_buffers, binding_tables);
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/iree/hal/drivers/hip/hip_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ static iree_status_t iree_hal_hip_device_queue_execute(
iree_hal_hip_device_t* device = iree_hal_hip_device_cast(base_device);
IREE_TRACE_ZONE_BEGIN(z0);

iree_status_t status = iree_hal_deferred_work_queue_enque(
iree_status_t status = iree_hal_deferred_work_queue_enqueue(
device->work_queue, iree_hal_hip_device_collect_tracing_context,
device->tracing_context, wait_semaphore_list, signal_semaphore_list,
command_buffer_count, command_buffers, binding_tables);
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/iree/hal/utils/deferred_work_queue.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ static void iree_hal_deferred_work_queue_decrement_work_items_count(
iree_slim_mutex_unlock(&actions->action_mutex);
}

iree_status_t iree_hal_deferred_work_queue_enque(
iree_status_t iree_hal_deferred_work_queue_enqueue(
iree_hal_deferred_work_queue_t* actions,
iree_hal_deferred_work_queue_cleanup_callback_t cleanup_callback,
void* callback_user_data,
Expand Down
7 changes: 4 additions & 3 deletions runtime/src/iree/hal/utils/deferred_work_queue.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ typedef void* iree_hal_deferred_work_queue_native_event_t;
typedef void* iree_hal_deferred_work_queue_host_device_event_t;

typedef struct iree_hal_deferred_work_queue_device_interface_vtable_t {
void (*destroy)(iree_hal_deferred_work_queue_device_interface_t*);
void(IREE_API_PTR* destroy)(
iree_hal_deferred_work_queue_device_interface_t* device_interface);
// Binds the device work queue to a thread. May be simulatneously
// bound to multiple threads.
iree_status_t(IREE_API_PTR* bind_to_thread)(
Expand Down Expand Up @@ -121,9 +122,9 @@ void iree_hal_deferred_work_queue_destroy(
typedef void(IREE_API_PTR* iree_hal_deferred_work_queue_cleanup_callback_t)(
void* user_data);

// Enques command buffer submissions into the work queue to be executed
// Enqueues command buffer submissions into the work queue to be executed
// once all semaphores have been satisfied.
iree_status_t iree_hal_deferred_work_queue_enque(
iree_status_t iree_hal_deferred_work_queue_enqueue(
iree_hal_deferred_work_queue_t* deferred_work_queue,
iree_hal_deferred_work_queue_cleanup_callback_t cleanup_callback,
void* callback_userdata,
Expand Down

0 comments on commit b6602e8

Please sign in to comment.