-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minzoom and maxzoom attribute error #226
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 83.74% 83.52% -0.23%
==========================================
Files 26 26
Lines 1046 1050 +4
==========================================
+ Hits 876 877 +1
- Misses 170 173 +3 |
localtileserver/client.py
Outdated
@@ -89,11 +89,17 @@ def band_names(self): | |||
|
|||
@property | |||
def min_zoom(self): | |||
return self.info.minzoom | |||
if hasattr(self, "info") and hasattr(self.info, "minzoom"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first hasattr check here isn't necessary as the client has info as a defined property. Just the secod check is all that is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been fixed. I wasn't sure if rio-tiler has removed the info attribute entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see what you mean. I’ll take a look at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Info class is still present, just min/max zoom attributes were removed.
Good to know. Thanks for confirming |
0.10.5 is tagged and should be released shortly |
rio-tiler v0.7.0.1 has removed min/max zoom attribute in the Info response.
Fix #225