Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[!feat] Refactor Htx #69

Merged
merged 9 commits into from
Sep 25, 2024
Merged

[!feat] Refactor Htx #69

merged 9 commits into from
Sep 25, 2024

Conversation

colmazia
Copy link
Contributor

@colmazia colmazia commented Sep 9, 2024

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

@colmazia colmazia changed the title update & refactor bothan-htx to match new bothan [!feat] Refactor Htx Sep 10, 2024
@colmazia colmazia marked this pull request as draft September 11, 2024 10:19
@colmazia colmazia marked this pull request as ready for review September 13, 2024 09:47
warittornc
warittornc reviewed Sep 16, 2024
View reviewed changes
bothan-htx/Cargo.toml Show resolved Hide resolved
bothan-htx/src/api/types.rs Outdated Show resolved Hide resolved
bothan-htx/src/api/types.rs Show resolved Hide resolved
bothan-htx/src/api/websocket.rs Outdated Show resolved Hide resolved
@colmazia colmazia merged commit 6b00841 into main Sep 25, 2024
3 checks passed
@colmazia colmazia deleted the update-htx branch September 25, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerKSI RogerKSI RogerKSI approved these changes

@warittornc warittornc warittornc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colmazia @RogerKSI @warittornc