Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base classes for code coverages #84

Merged
merged 2 commits into from
May 7, 2024

Conversation

ominusliticus
Copy link
Collaborator

There is no way to construct an abstract base class in python. Therefore, there is no way to have code coverage check the lines that have return NotImplemented. Simply have a doc-string (or pass if there is no doc-string) is enough.

@ominusliticus
Copy link
Collaborator Author

I will add here, as a comment for the permanent record, that our abs tract methods should have return NotImplementedError, instead of NotImplemented. However, reading the Python documentation, it seems the decorating the methods with @abtractmethod does this for us by requiring inheritors of the Abstract Base Class (ABC), to implemented all functions decorated as abstract.

@ominusliticus ominusliticus merged commit ccc6a2a into bandframework:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant