Testing Taweret workflow #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made additions to .rst and python docstring docs to see that they are rendered locally by tox, that they are visible in the RTD test rendering for the PR, but not published in the official, public RTD docs. They did show up as expected with tox. NOTE: I want these to make it into main so that we do see them automatically incluced in the official, public RTD docs. We can then remove them as a hotfix to test the whole workflow. Note that these were also added in to generate a merge conflict with the changes made direclty on main at commit d53cbfe so that we can test the git workflow a bit as well.
Some were running on edits to PR conversations as well as upon closing. Revert to default, which seems to be working for other PR actions. If we want actions to run upon merging, then we will make actions on special branches in accord with the git workflow to run on pushes to the branch.
Finalize publishing sphinx docs to RTD
|
Did the resolution by hand as discussed. Tests running currently. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 14 14
Lines 1554 1554
=======================================
Hits 1039 1039
Misses 515 515 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we're looking at how the Taweret workflow might look if we have pushes into
developthat pass there but then do not pass tomain, ifmainhas some other commits that haven't been merged back intodevelop. This requires us to choose to resolve these conflicts by hand.