Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faet: added support for k8s auth method #45

Merged
merged 1 commit into from
Jan 9, 2024
Merged

faet: added support for k8s auth method #45

merged 1 commit into from
Jan 9, 2024

Conversation

gabheadz
Copy link
Contributor

@gabheadz gabheadz commented Jan 9, 2024

  • Vault Secret Manager: Added support for authenticating vault with k8s as specified in vault documentation.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
94.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gabheadz gabheadz requested a review from juancgalvis January 9, 2024 22:03
@gabheadz gabheadz merged commit 3b41c1d into master Jan 9, 2024
7 of 9 checks passed
@gabheadz gabheadz deleted the feature/vault-secrets-k8s branch January 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancgalvis juancgalvis juancgalvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabheadz @juancgalvis