Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SecretsManager version #19

Merged
merged 11 commits into from
Mar 1, 2021
Merged

New SecretsManager version #19

merged 11 commits into from
Mar 1, 2021

Conversation

andmagom
Copy link
Contributor

@andmagom andmagom commented Feb 27, 2021 •
edited
Loading

New version

3.0.0

Changes

  • Async connector renamed

Fixes

  • Package name fixed
  • Sonar Enabled
  • Ignored Tests enabled
  • new tests added
  • multi module coverage fixed
  • Code duplicated deleted

Contributors

@andmagom

@andmagom andmagom changed the title Fixed some errors New SecretsManager version Feb 28, 2021
@andmagom andmagom marked this pull request as ready for review February 28, 2021 00:48
@andmagom andmagom requested review from alejobtc and dericop February 28, 2021 00:49
@alejobtc alejobtc self-requested a review February 28, 2021 15:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

73.5% 73.5% Coverage
0.0% 0.0% Duplication

@andmagom andmagom merged commit 684fcf4 into master Mar 1, 2021
@andmagom andmagom deleted the feature/fixRepo branch March 2, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dericop dericop Awaiting requested review from dericop

@alejobtc alejobtc Awaiting requested review from alejobtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andmagom @alejobtc