Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When base option is set, files outside base dir should be ignored. #345

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

vdecrombecque
Copy link

When base option is set, files outside base dir should be ignored.
Fix in directories creation.

Copy link
Owner

@banago banago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can manually include files outside the base dir. Why do you want to force this behavior?

@@ -266,7 +266,7 @@ public function __construct()
$this->cli = $this->opt->cli;

$this->cli->backgroundGreen()->bold()->out('-------------------------------------------------');
$this->cli->backgroundGreen()->bold()->out('| PHPloy |');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we use phploy with gitlab ci and we want the phploy version used stored in the deployment log.
So we replace this line with : $this->cli->backgroundGreen()->bold()->out('PHPloy version ' . $this->version);

@banago
Copy link
Owner

banago commented Apr 19, 2018

You can manually include files outside the base dir. Why do you want to force this behavior?

@vdecrombecque
Copy link
Author

Thanks for your work and for your feedback!
Exclude files outside base dir manualy doesn't suit our need. In case of addition of a file or dir outside the base dir, it will be puplished..

@tazeverywhere
Copy link

tazeverywhere commented May 3, 2018

I can confirm this bug, files outside the base are not ignored.
This commit , merged with 4.8.5, fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants