-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When base option is set, files outside base dir should be ignored. #345
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can manually include files outside the base dir. Why do you want to force this behavior?
@@ -266,7 +266,7 @@ public function __construct() | |||
$this->cli = $this->opt->cli; | |||
|
|||
$this->cli->backgroundGreen()->bold()->out('-------------------------------------------------'); | |||
$this->cli->backgroundGreen()->bold()->out('| PHPloy |'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we use phploy with gitlab ci and we want the phploy version used stored in the deployment log.
So we replace this line with : $this->cli->backgroundGreen()->bold()->out('PHPloy version ' . $this->version);
You can manually include files outside the base dir. Why do you want to force this behavior? |
Thanks for your work and for your feedback! |
I can confirm this bug, files outside the |
When base option is set, files outside base dir should be ignored.
Fix in directories creation.