Add Support for Rollbacks

[banago]

Support for rollback to earlier version is being developed. You can view progress on the rollbacks branch.

It is expect to allow you to rollback to previous version by running:

phploy --rollback

Or to a more earlier version by running:

phploy --rollback revision-id

Suggestions are welcome.

[banago]

Hi @SimonEast,

If you reset your HEAD back and then ran the deploy again, is it possible for the script to detect the changes deploy the changed files (kind of in reverse?).

I'm thinking it would be better to let the script to do the checkout the the required commit and then push that commit, rather then do it manually. What do you think?

About the reset I don't know since it seem you loose history if you run it. I have to test this.

Please let me know.

[SimonEast]

Yeah good point, it would be better to call --rollback with or without the
revision-id.

If you left out the revision-id, would it deploy the previous commit, or
the previous *deployed commit *(can the script determine which one that
was)?

Simon.

[banago]

@SimonEast to keep it simple and to the point, phploy --rollback without a revision id, will roll one step back current HEAD. And if you want to revert to another revision, you just provide the revision. I think this is the best approach, otherwise it becomes a little complicated to use.

[SimonEast]

Yeah, sounds good. It's much easier to code that way. Just be clear in
the docs that that's how it works. :-)

[banago]

@SimonEast and @fadion - I think I've bumped into a Git bug. So, if I run the same command form the terminal and get a different result from the same one executed form PHP. The git command run in both cases is:

git diff --name-status HEAD^ ...revision-id

But results for deleted and added files are swapped. Check out the attached image. One says test.txt is added and the other was says it is deleted.

The command run through terminal returns the right results.

Could you please pull the rollbacks branch and test on your environments please?

[banago]

Wow, one space makes a big difference in Git 😄

banago@work:knr-flatrock$ git diff --name-status HEAD^...c7b3a3e85dedb688fcb49750c5952636f2c80990
A       testing-deploy-again.txt
D       testing-deploy.txt
banago@work:knr-flatrock$ git diff --name-status HEAD^ ...c7b3a3e85dedb688fcb49750c5952636f2c80990
DDD     testing-deploy-again.txt
AAA     testing-deploy.txt

It's high time we get into Unit Testing @fadion - I'm growing white hair because of this kind of debugging. 😸

[fadion]

Just a space? Interesting...

[banago]

Yes sir - last thing I would think of...

[fadion]

When you're finished with the rollback featured, want me to make a "rewrite"? Mostly coding style (psr2 compliance), because it's a mix of styles, but some small things could be easily rewritten too. Nothing big anyway.

PS: Didn't want to open a new issue.

[banago]

Oh, yes please. I was thinking to ask you for a tool to help me with all the styling rules - not yet completely in my system :)

Go ahead and open an issue for that - it helps us to see what we are doing next.