Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation following good inferencedata practices #537

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

aloctavodia
Copy link
Collaborator

@aloctavodia aloctavodia commented Jun 16, 2022

Closes #538

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #537 (7983382) into main (425b7b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          32       32           
  Lines        2611     2611           
=======================================
  Hits         2266     2266           
  Misses        345      345           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425b7b8...7983382. Read the comment docs.

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

tomicapretto commented on 2022-06-20T14:42:16Z
----------------------------------------------------------------

I added the plt.rcParams['figure.constrained_layout.use'] = False to remove the warning that appears when calling plot_data(data). That's because the "arviz-darkgrid" style seems to be using plt.tight_layout(). Is it possible to avoid that?


@tomicapretto
Copy link
Collaborator

Only small comments. I think this can be merged.

Apart from that, I've seen some examples where the density estimates were terribly wiggly. Now it is fixed. Do you know why that happened?

@aloctavodia
Copy link
Collaborator Author

Thanks for the comments, I will address them and also add the rest of the notebooks, I am almost finished making changes.

No idea what happened with the wigglyness, is a complete mystery to me.

@aloctavodia
Copy link
Collaborator Author

We are good to merge, unless there are more comments @tomicapretto

@tomicapretto
Copy link
Collaborator

Looks good! Let's merge now :)

@tomicapretto tomicapretto merged commit 15863dc into bambinos:main Jun 21, 2022
@aloctavodia aloctavodia deleted the doc_idata branch June 21, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to follow good InferenceData practices
3 participants