-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation following good inferencedata practices #537
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 32 32
Lines 2611 2611
=======================================
Hits 2266 2266
Misses 345 345 Continue to review full report at Codecov.
|
View / edit / reply to this conversation on ReviewNB tomicapretto commented on 2022-06-20T14:42:16Z I added the |
Only small comments. I think this can be merged. Apart from that, I've seen some examples where the density estimates were terribly wiggly. Now it is fixed. Do you know why that happened? |
Thanks for the comments, I will address them and also add the rest of the notebooks, I am almost finished making changes. No idea what happened with the wigglyness, is a complete mystery to me. |
We are good to merge, unless there are more comments @tomicapretto |
Looks good! Let's merge now :) |
Closes #538