Fix PHPStan issues (#128)

bamarni · Jul 14, 2022 · 737a982 · 737a982
1 parent cb30cae
commit 737a982
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/src/BinCommand.php b/src/BinCommand.php
@@ -217,7 +217,7 @@ private function executeInNamespace(
         $this->logger->logDebug(
             sprintf(
                 'Running <info>`@composer %s`</info>.',
-                $namespaceInput
+                $namespaceInput->__toString()
             )
         );
 

diff --git a/src/BinInputFactory.php b/src/BinInputFactory.php
@@ -31,7 +31,7 @@ public static function createInput(
                 '/^(?<preBinOptions>.+)?bin (?:(?<preBinOptions2>.+?) )?(?:%1$s|\'%1$s\') (?<binCommand>.+?)(?<extraInput> -- .*)?$/',
                 preg_quote($namespace, '/')
             ),
-            (string) $previousInput,
+            $previousInput->__toString(),
             $matches
         );
 
@@ -62,7 +62,7 @@ public static function createNamespaceInput(InputInterface $previousInput): Inpu
     {
         $matchResult = preg_match(
             '/^(.+?\s?)(--(?: .+)?)?$/',
-            (string) $previousInput,
+            $previousInput->__toString(),
             $matches
         );
 
@@ -91,7 +91,7 @@ public static function createForwardedCommandInput(InputInterface $input): Input
         return new StringInput(
             sprintf(
                 'bin all %s',
-                (string) $input
+                $input->__toString()
             )
         );
     }

diff --git a/src/InvalidBinInput.php b/src/InvalidBinInput.php
@@ -15,7 +15,7 @@ public static function forBinInput(InputInterface $input): self
         return new self(
             sprintf(
                 'Could not parse the input "%s". Expected the input to be in the format "bin <namespaceName> <commandToExecuteInBinNamespace>", for example "bin all update --prefer-lowest".',
-                $input
+                $input->__toString()
             )
         );
     }
@@ -25,7 +25,7 @@ public static function forNamespaceInput(InputInterface $input): self
         return new self(
             sprintf(
                 'Could not parse the input (executed within the namespace) "%s".',
-                $input
+                $input->__toString()
             )
         );
     }

diff --git a/src/Plugin.php b/src/Plugin.php
@@ -143,7 +143,7 @@ protected function onForwardedCommand(
         $this->logger->logDebug(
             sprintf(
                 'Original input: <comment>%s</comment>.',
-                $input
+                $input->__toString()
             )
         );
 

diff --git a/tests/BinCommandTest.php b/tests/BinCommandTest.php
@@ -60,7 +60,9 @@ protected function setUp(): void
 
         chdir($tmpDir);
         // On OSX sys_get_temp_dir() may return a symlink
-        $this->tmpDir = realpath($tmpDir);
+        $tmpDirRealPath = realpath($tmpDir);
+        self::assertNotFalse($tmpDirRealPath);
+        $this->tmpDir = $tmpDirRealPath;
 
         file_put_contents(
             $this->tmpDir.'/composer.json',