fixed match plugin #2781
fixed match plugin #2781
Conversation
|
WalkthroughThis pull request includes updates to multiple projects within the Ballerine ecosystem, primarily focusing on version increments for dependencies. The changes encompass updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (3)
packages/common/CHANGELOG.md (1)
3-7: Consider providing more context in the changelog entry.The changelog entry follows the correct format and the version number is properly incremented. However, the description "fix match schema" could be more informative. Consider expanding on what specific aspect of the match schema was fixed or what issue this fix addresses.
For example:
- Fixed validation in match schema to prevent [specific issue]This would provide more context to users and developers about the nature and impact of the change.
sdks/web-ui-sdk/CHANGELOG.md (1)
3-8: LGTM! Consider adding more details to the changelog entry.The changelog entry for version 1.5.43 correctly follows the established format and appropriately documents the update to the @ballerine/common dependency.
To improve the changelog's informativeness, consider adding a brief note about any significant changes or fixes introduced by this dependency update. For example:
## 1.5.43 ### Patch Changes - Updated dependencies - @ballerine/common@0.9.42 - Note: This update includes [brief description of any notable changes or fixes]This additional context can help users understand the impact of the update.
packages/workflow-core/CHANGELOG.md (1)
3-8: LGTM! Consider adding a brief description of the change.The new changelog entry for version 0.6.54 is correctly formatted and consistent with previous entries. It properly documents the update of the
@ballerine/commondependency to version 0.9.42.To improve clarity, consider adding a brief description of any notable changes or the reason for the version bump, if applicable. For example:
## 0.6.54 ### Patch Changes - Updated dependencies - @ballerine/common@0.9.42 - Brief description of any notable changes or reason for the version bump
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
- apps/backoffice-v2/CHANGELOG.md (1 hunks)
- apps/backoffice-v2/package.json (2 hunks)
- apps/kyb-app/CHANGELOG.md (1 hunks)
- apps/kyb-app/package.json (2 hunks)
- examples/headless-example/CHANGELOG.md (1 hunks)
- examples/headless-example/package.json (2 hunks)
- packages/common/CHANGELOG.md (1 hunks)
- packages/common/package.json (1 hunks)
- packages/common/src/schemas/documents/merchant-screening-plugin-schema.ts (1 hunks)
- packages/workflow-core/CHANGELOG.md (1 hunks)
- packages/workflow-core/package.json (2 hunks)
- sdks/web-ui-sdk/CHANGELOG.md (1 hunks)
- sdks/web-ui-sdk/package.json (2 hunks)
- sdks/workflow-browser-sdk/CHANGELOG.md (1 hunks)
- sdks/workflow-browser-sdk/package.json (2 hunks)
- sdks/workflow-node-sdk/CHANGELOG.md (1 hunks)
- sdks/workflow-node-sdk/package.json (2 hunks)
- services/workflows-service/CHANGELOG.md (1 hunks)
- services/workflows-service/package.json (2 hunks)
- websites/docs/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (7)
- apps/backoffice-v2/package.json
- apps/kyb-app/CHANGELOG.md
- examples/headless-example/package.json
- packages/common/package.json
- sdks/workflow-browser-sdk/CHANGELOG.md
- services/workflows-service/CHANGELOG.md
- services/workflows-service/package.json
🧰 Additional context used
🔇 Additional comments (11)
packages/workflow-core/package.json (1)
4-4: LGTM: Version bump is appropriate.The minor version update from 0.6.53 to 0.6.54 is consistent with semantic versioning principles for backwards-compatible changes.
apps/kyb-app/package.json (3)
4-4: LGTM: Version bump looks good.The version update from 0.3.67 to 0.3.68 is consistent with the changes made to the dependencies. This minor version increment suggests backward-compatible updates or bug fixes.
19-19: LGTM: Dependency update for @ballerine/common.The update of @ballerine/common from ^0.9.41 to ^0.9.42 is a minor version bump, which should maintain backward compatibility.
To ensure compatibility, please run the following script:
21-21: LGTM: Dependency update for @ballerine/workflow-browser-sdk.The update of @ballerine/workflow-browser-sdk from 0.6.53 to 0.6.54 is a patch version bump, indicating backward-compatible bug fixes.
To ensure compatibility, please run the following script:
✅ Verification successful
: The update to
@ballerine/workflow-browser-sdkversion0.6.54has been verified. No breaking changes or deprecation warnings were found in the changelogs, and the dependency update is safe to proceed.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the compatibility of the updated @ballerine/workflow-browser-sdk package # Test: Check for any breaking changes or deprecation warnings in the changelog rg --type md -i '(breaking change|deprecat)' -A 5 -g 'CHANGELOG.md' 'workflow-browser-sdk' # Test: Verify that the package is being used correctly after the update ast-grep --lang typescript --pattern '$_.$_' | rg '@ballerine/workflow-browser-sdk'Length of output: 233
Script:
#!/bin/bash # Description: Locate the CHANGELOG.md file in the repository # Search for CHANGELOG.md in the repository fd CHANGELOG.md # If found, search for breaking changes or deprecation warnings related to workflow-browser-sdk rg --type md -i '(breaking change|deprecat)' -A 5 -g 'CHANGELOG.md' 'workflow-browser-sdk' # Refined Test: Verify that the package is being used correctly after the update ast-grep --lang typescript --pattern 'import $_ from "@ballerine/workflow-browser-sdk"'Length of output: 986
sdks/web-ui-sdk/package.json (3)
Line range hint
1-107: Summary: Minor version updates applied correctly.The changes in this file are minimal and focused on version updates:
- The package version has been incremented from 1.5.42 to 1.5.43.
- The @ballerine/common dependency has been updated from 0.9.41 to 0.9.42.
These updates are consistent with the PR objectives and maintain the overall structure of the package.json file.
99-99: LGTM: Dependency update looks good.The @ballerine/common dependency has been correctly updated from version 0.9.41 to 0.9.42.
To ensure compatibility, please verify that this update doesn't introduce any breaking changes. You can check the changelog of @ballerine/common for version 0.9.42 using the following script:
#!/bin/bash # Description: Check the changelog of @ballerine/common for version 0.9.42 # Test: Search for version 0.9.42 in the changelog of @ballerine/common. Expect: At least one occurrence. changelog_path=$(fd -t f CHANGELOG.md | grep -i "common") if [ -n "$changelog_path" ] && grep -q "0.9.42" "$changelog_path"; then echo "Changelog for @ballerine/common 0.9.42 found. Please review the changes." grep -A 10 "0.9.42" "$changelog_path" else echo "Warning: Changelog for @ballerine/common 0.9.42 not found or version not mentioned." fi
24-24: LGTM: Version update looks good.The package version has been correctly incremented from 1.5.42 to 1.5.43, following semantic versioning principles for a patch update.
Please ensure that the CHANGELOG.md file has been updated to reflect this version change. You can verify this with the following script:
✅ Verification successful
LGTM: CHANGELOG.md has been successfully updated with version 1.5.43.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if CHANGELOG.md has been updated with the new version # Test: Search for the new version in CHANGELOG.md. Expect: At least one occurrence. if grep -q "1.5.43" CHANGELOG.md; then echo "CHANGELOG.md has been updated with version 1.5.43" else echo "Warning: CHANGELOG.md may not have been updated with version 1.5.43" fiLength of output: 472
Script:
#!/bin/bash # Description: Check if CHANGELOG.md for @ballerine/web-ui-sdk has been updated with version 1.5.43 # Search for the web-ui-sdk CHANGELOG.md changelog_path=$(fd -t f "CHANGELOG.md" sdks/web-ui-sdk/) if [ -n "$changelog_path" ]; then # Search for the new version in the CHANGELOG.md if grep -q "1.5.43" "$changelog_path"; then echo "CHANGELOG.md has been updated with version 1.5.43 in $changelog_path" else echo "Warning: CHANGELOG.md in $changelog_path may not have been updated with version 1.5.43" fi else echo "Warning: CHANGELOG.md for @ballerine/web-ui-sdk not found." fiLength of output: 347
packages/common/src/schemas/documents/merchant-screening-plugin-schema.ts (1)
417-417: LGTM! Verify usage in the codebase.The change from
terminatedMatchedMerchanttoterminatedMatchedMerchantsimproves clarity by accurately reflecting that this property represents an array of terminated matched merchants. This is a positive change that enhances the schema's readability and consistency.To ensure this change doesn't introduce any breaking changes, please run the following script to check for any occurrences of the old property name in the codebase:
If any occurrences are found, please update them to use the new property name
terminatedMatchedMerchants.sdks/workflow-node-sdk/CHANGELOG.md (1)
3-7: LGTM: New changelog entry is correct and consistent.The new entry for version 0.6.54 is properly formatted and consistent with previous entries. It correctly indicates a patch change and clearly states the updated dependency.
examples/headless-example/CHANGELOG.md (1)
3-10: LGTM: New version entry is correctly formatted and documented.The addition of version 0.3.53 follows the established changelog format and accurately documents the dependency updates for @ballerine/common and @ballerine/workflow-browser-sdk.
apps/backoffice-v2/CHANGELOG.md (1)
3-10: LGTM: Version 0.7.57 changes look good.The CHANGELOG has been updated correctly with the new version 0.7.57. The dependency updates are clearly listed, showing increments for @ballerine/common, @ballerine/workflow-browser-sdk, and @ballerine/workflow-node-sdk.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores