Add Readme file #5
Conversation
Add Readme file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 86.59% 86.59%
Complexity 9 9
=========================================
Files 7 7
Lines 649 649
Branches 381 381
=========================================
Hits 562 562
Misses 84 84
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Add code owners to this repo |
Add spec and code owners
This was addressed in 6dd6600 |
Update spec to Ballerina extended lib spec
| # See: https://help.github.com/articles/about-codeowners/ | ||
|
|
||
| # These owners will be the default owners for everything in the repo. | ||
| * @daneshk @niveathika @dinukaamarasinghe817 |
There was a problem hiding this comment.
I don't think we can have @dinukaamarasinghe817 as a code owner as he is not a commiter of this repo yet :) Thats why Github is also indicating an error in here.
| * @daneshk @niveathika @dinukaamarasinghe817 | |
| * @daneshk @niveathika @dinukaamarasinghe817 |
There was a problem hiding this comment.
I think It shows the same error for @daneshk and @niveathika as well.
There was a problem hiding this comment.
This is what I'm seeing 🤔 Is it different for you?
There was a problem hiding this comment.
After removing @dinukaamarasinghe817 from CODEOWNERS I get this.
For example, It says Unknown owner: make sure @daneshk exists and has write access to the repository when I hover over the error.
There was a problem hiding this comment.
This might be because I'm checking this in my forked repository. I'll send a PR to see if it's work in ballerina-platform/module-ballerinax-persist.redis repository
Purpose
Fixes: ballerina-platform/ballerina-library#6136
Examples
Checklist