Add Redis DB support for bal persist #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage ? 86.59%
Complexity ? 9
=======================================
Files ? 7
Lines ? 649
Branches ? 381
=======================================
Hits ? 562
Misses ? 84
Partials ? 3 ☔ View full report in Codecov by Sentry. |
Nuvindu
reviewed
Mar 1, 2024
| name: Run Build Workflow | ||
| if: ${{ github.repository_owner == 'ballerina-platform' }} | ||
| uses: ballerina-platform/ballerina-library/.github/workflows/build-timestamp-master-template.yml@main | ||
| secrets: inherit |
There was a problem hiding this comment.
Suggested change
| secrets: inherit | |
| secrets: inherit | |
.github/workflows/trivy-scan.yml
Outdated
| name: Run Trivy Scan Workflow | ||
| if: ${{ github.repository_owner == 'ballerina-platform' }} | ||
| uses: ballerina-platform/ballerina-library/.github/workflows/trivy-scan-template.yml@main | ||
| secrets: inherit |
There was a problem hiding this comment.
Suggested change
| secrets: inherit | |
| secrets: inherit | |
ballerina/Module.md
Outdated
| @@ -0,0 +1,50 @@ | |||
| # Module Overview | |||
There was a problem hiding this comment.
Suggested change
| # Module Overview | |
| # Overview |
| import ballerina/test; | ||
| import ballerina/persist; |
There was a problem hiding this comment.
Suggested change
| import ballerina/test; | |
| import ballerina/persist; | |
| import ballerina/persist; | |
| import ballerina/test; |
| private typedesc<record {}> targetType; | ||
| private map<anydata> typeMap; | ||
|
|
||
| public isolated function init(stream<record {}, error?>? anydataStream, typedesc<record {}> targetType, map<anydata> typeMap, string[] fields, string[] include, any[] typeDescriptions, RedisClient persistClient, persist:Error? err = ()) { |
There was a problem hiding this comment.
Check for the lines which are exceeding the maximum length
There was a problem hiding this comment.
@dinukaamarasinghe817 can you break it down to multiple lines?
daneshk
reviewed
Mar 2, 2024
daneshk
reviewed
Mar 2, 2024
daneshk
reviewed
Mar 2, 2024
daneshk
reviewed
Mar 5, 2024
daneshk
reviewed
Mar 5, 2024
daneshk
reviewed
Mar 5, 2024
daneshk
reviewed
Mar 5, 2024
Fix formatting issues
daneshk
reviewed
Mar 6, 2024
daneshk
reviewed
Mar 6, 2024
Fix issues with metadata visibility
daneshk
reviewed
Mar 10, 2024
daneshk
reviewed
Mar 10, 2024
daneshk
previously approved these changes
Mar 10, 2024
Update configs to use Redis connector v3
|
Please note that I have updated the configurations to use the new |
Update git ignore to omit IDEA generated files
Update git ignore to omit IDEA generated files
daneshk
reviewed
Mar 11, 2024
Add a new line in Config.toml file
daneshk
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To make data persistence easier for
bal persistwith Redis DB.Addressing : https://github.com/ballerina-platform/persist-tools/issues/328
Goals
To support Redis as a database for the
bal persistfeature which allows users to manage data persistence without writing database queries inside the code. We need to generate the persistence client code for Redis when the ‘bal persist generate’ command gets executed.Architecture
Approach
Implements a generic client for Redis which contains resource methods to get, insert, update and delete records. This utilizes main data types supported by Redis which are Hashes and Sets. This also includes a Java native processor to support dependent types in get resource methods.
Documentation
Design Documentation : Link
Related PRs
Related to : #3
Related to : #2
Future Improvements
Revisit after : ballerina-platform/ballerina-library#6136
Revisit after : ballerina-platform/ballerina-library#6137