Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live tests and mock tests #4

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

roshanemoraes
Copy link
Contributor

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@MohamedSabthar MohamedSabthar merged commit 3b878e3 into ballerina-platform:main Jan 17, 2025
2 checks passed
import ballerina/oauth2;
import ballerinax/hubspot.crm.commerce.orders as orders;
import ballerinax/hubspot.crm.commerce.orders as hsOrders;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use camel case in package qualifiers. (Package qualifiers are treated differently than the variables, since they kind of act like a namespace).

Suggested change
import ballerinax/hubspot.crm.commerce.orders as hsOrders;
import ballerinax/hubspot.crm.commerce.orders as hsorders;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants