Skip to content

Commit

Permalink
Merge pull request #240 from ayeshLK/main
Browse files Browse the repository at this point in the history
Exclude `netty-buffer` and `jackson-annotations` from the native-jar
  • Loading branch information
NipunaRanasinghe authored Oct 1, 2024
2 parents e1d9e0a + 5af49fb commit 84f36ff
Show file tree
Hide file tree
Showing 7 changed files with 47 additions and 4 deletions.
18 changes: 15 additions & 3 deletions ballerina/Ballerina.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
distribution = "2201.8.0"
org = "ballerinax"
name = "asb"
version = "3.8.1"
version = "3.8.2-SNAPSHOT"
license= ["Apache-2.0"]
authors = ["Ballerina"]
keywords = ["IT Operations/Message Brokers", "Cost/Paid", "Vendor/Microsoft"]
Expand All @@ -19,5 +19,17 @@ graalvmCompatible = true
groupId = "org.ballerinax"
artifactId = "asb-native"
module = "asb-native"
version = "3.8.1"
path = "../native/build/libs/asb-native-3.8.1.jar"
version = "3.8.2-SNAPSHOT"
path = "../native/build/libs/asb-native-3.8.2-SNAPSHOT.jar"

[[platform.java17.dependency]]
groupId = "com.fasterxml.jackson.core"
artifactId = "jackson-annotations"
version = "2.13.5"
path = "./lib/jackson-annotations-2.13.5.jar"

[[platform.java17.dependency]]
groupId = "io.netty"
artifactId = "netty-buffer"
version = "4.1.94.Final"
path = "./lib/netty-buffer-4.1.94.Final.jar"
2 changes: 1 addition & 1 deletion ballerina/Dependencies.toml
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ modules = [
[[package]]
org = "ballerinax"
name = "asb"
version = "3.8.1"
version = "3.8.2-SNAPSHOT"
dependencies = [
{org = "ballerina", name = "jballerina.java"},
{org = "ballerina", name = "lang.runtime"},
Expand Down
11 changes: 11 additions & 0 deletions ballerina/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,21 @@ configurations {
externalJars
}

dependencies {
externalJars(group: 'com.fasterxml.jackson.core', name: 'jackson-annotations', version: "${jacksonVersion}") {
transitive = false
}
externalJars(group: 'io.netty', name: 'netty-buffer', version: "${nettyVersion}") {
transitive = false
}
}

task updateTomlFiles {
doLast {
def newBallerinaToml = ballerinaTomlFilePlaceHolder.text.replace("@project.version@", project.version)
newBallerinaToml = newBallerinaToml.replace("@toml.version@", tomlVersion)
newBallerinaToml = newBallerinaToml.replace("@jackson.version@", project.jacksonVersion)
newBallerinaToml = newBallerinaToml.replace("@netty.version@", project.nettyVersion)
ballerinaTomlFile.text = newBallerinaToml
}
}
Expand Down
12 changes: 12 additions & 0 deletions build-config/resources/Ballerina.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,15 @@ artifactId = "asb-native"
module = "asb-native"
version = "@project.version@"
path = "../native/build/libs/asb-native-@project.version@.jar"

[[platform.java17.dependency]]
groupId = "com.fasterxml.jackson.core"
artifactId = "jackson-annotations"
version = "@jackson.version@"
path = "./lib/jackson-annotations-@jackson.version@.jar"

[[platform.java17.dependency]]
groupId = "io.netty"
artifactId = "netty-buffer"
version = "@netty.version@"
path = "./lib/netty-buffer-@netty.version@.jar"
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- [Application written with `ballerina/asb` connector gives a conflicting JAR warning with `netty-buffer` and `jackson-annotations`](https://github.com/ballerina-platform/ballerina-library/issues/7061)

## [3.8.1] - 2024-09-30

### Fixed
Expand Down
2 changes: 2 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ ballerinaGradlePluginVersion=2.2.4
ballerinaLangVersion=2201.8.0
azureServiceBusVersion=7.14.3
slf4jVersion=1.7.30
nettyVersion=4.1.94.Final
jacksonVersion=2.13.5
2 changes: 2 additions & 0 deletions native/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ dependencies {
dist (group: 'com.azure', name: 'azure-messaging-servicebus', version: "${azureServiceBusVersion}") {
exclude group: "com.fasterxml.woodstox", module: "woodstox-core"
exclude group: "org.codehaus.woodstox", module: "stax2-api"
exclude group: "com.fasterxml.jackson.core", module: "jackson-annotations"
exclude group: "io.netty", module: "netty-buffer"
}
}

Expand Down

0 comments on commit 84f36ff

Please sign in to comment.