Implement dynamodb streams connector #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement DynamoDB streams connector
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Update docs
Update test cases
Remove unused imports
Refactor the code
Refactor the code
daneshk
reviewed
Jan 8, 2024
| @@ -0,0 +1,41 @@ | |||
| name: GraalVM Check | |||
There was a problem hiding this comment.
Do we need both native and graalvm workflows?
There was a problem hiding this comment.
We don't need it. Removed with 2cc8a76
Address review suggestions
daneshk
reviewed
Jan 8, 2024
daneshk
reviewed
Jan 8, 2024
daneshk
reviewed
Jan 8, 2024
ballerina/constatnts.bal
Outdated
|
|
||
| const string GENERATE_SIGNED_REQUEST_HEADERS_FAILED_MSG = "Error occurred while generating signed request headers."; | ||
|
|
||
| public enum AttributeType { |
There was a problem hiding this comment.
Shall we add API docs for public enums. This will appear in API Docs.
There was a problem hiding this comment.
Added docs for enum types.
daneshk
reviewed
Jan 8, 2024
ballerina/stream_implementor.bal
Outdated
| } | ||
|
|
||
| public isolated function next() returns record {| Stream value; |}|error? { | ||
| if (self.index < self.currentEntries.length()) { |
There was a problem hiding this comment.
Suggested change
| if (self.index < self.currentEntries.length()) { | |
| if self.index < self.currentEntries.length() { |
daneshk
reviewed
Jan 8, 2024
| @@ -0,0 +1,43 @@ | |||
| import ballerina/io; | |||
daneshk
reviewed
Jan 8, 2024
ballerina/constatnts.bal
Outdated
| @@ -0,0 +1,88 @@ | |||
| // Copyright (c) 2024, WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
typo in the filename constants.bal
Address review suggestions
Co-authored-by: Danesh Kuruppu <daneshk@users.noreply.github.com>
Add the removed constants.bal
Add shard iterator type
daneshk
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the DynamoDB Streams connector.
Fixes : ballerina-platform/ballerina-library#5801