-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dispatching custom error remote functions #1356
Conversation
private static String getCustomRemoteMethodName(String dispatchingKey, | ||
WebSocketConnectionInfo.StringAggregator stringAggregator) { | ||
if (null == dispatchingKey) { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use optionals here rather than using null ?
// If any runtime error occurs while retrieving the dispatching value, the default method(onMessage) | ||
// name will be used. | ||
} catch (RuntimeException e) { | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to this comment [1]
[1] - https://github.com/ballerina-platform/module-ballerina-websocket/pull/1356/files#r1656468643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in affa6f8
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Purpose
Introduce support to dispatch custom error remote functions. When there is a data binding error related to a custom remote function, if the WebSocket service has a custom error remote function associated with that particular custom remote function, that error remote function will get dispatched.
Related issue: ballerina-platform/ballerina-library#6625
Examples
For example,
Checklist