Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persist compiler crash when no persist configurations are found #278

Merged

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Mar 25, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#6187

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.75%. Comparing base (7048f30) to head (125487e).

Files Patch % Lines
.../persist/compiler/utils/ValidatorsByDatastore.java 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #278      +/-   ##
============================================
- Coverage     88.37%   87.75%   -0.63%     
  Complexity      365      365              
============================================
  Files            30       30              
  Lines          1170     1176       +6     
  Branches        145      148       +3     
============================================
- Hits           1034     1032       -2     
- Misses           85       91       +6     
- Partials         51       53       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bhashinee and others added 2 commits April 2, 2024 10:26
Co-authored-by: Danesh Kuruppu <daneshk@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daneshk daneshk merged commit b981b10 into ballerina-platform:main Apr 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix persist compiler crash when no persist configurations are found
2 participants