Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTP/2 IDLE based eviction #2277

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Implement HTTP/2 IDLE based eviction #2277

wants to merge 10 commits into from

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Jan 21, 2025

Purpose

Fixes: ballerina-platform/ballerina-library#7309

Examples

Refer to the attached issue

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (0d1c9f5) to head (8d18ce1).

Files with missing lines Patch % Lines
...tractimpl/sender/http2/Http2ConnectionManager.java 89.18% 2 Missing and 2 partials ⚠️

❌ Your project check has failed because the head coverage (79.96%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2277      +/-   ##
============================================
- Coverage     80.40%   79.96%   -0.45%     
- Complexity        0      678     +678     
============================================
  Files           367      418      +51     
  Lines         20757    23157    +2400     
  Branches       3294     3757     +463     
============================================
+ Hits          16690    18517    +1827     
- Misses         3133     3508     +375     
- Partials        934     1132     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review January 23, 2025 04:51
Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The IDLE based eviction is not supported for HTTP/2 connections
1 participant