Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validateDocument function to validate the entire document and return all validation errors at once #950

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Sep 28, 2022

Purpose

Fixes: #2848

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 88.71% // Head: 88.46% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (34d7152) compared to base (5eb48ba).
Patch coverage: 60.97% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   88.71%   88.46%   -0.25%     
==========================================
  Files          57       57              
  Lines        4377     4414      +37     
  Branches     2514     2527      +13     
==========================================
+ Hits         3883     3905      +22     
- Misses        464      479      +15     
  Partials       30       30              
Impacted Files Coverage Δ
ballerina/modules/parser/argument_node.bal 58.69% <20.00%> (-4.72%) ⬇️
ballerina/modules/parser/fragment_node.bal 57.77% <20.00%> (-10.80%) ⬇️
ballerina/modules/parser/operation_node.bal 70.00% <20.00%> (-7.15%) ⬇️
ballerina/engine.bal 96.91% <100.00%> (+0.59%) ⬆️
ballerina/field_validator_visitor.bal 96.84% <100.00%> (+0.05%) ⬆️
ballerina/fragment_cycle_finder_visitor.bal 88.88% <100.00%> (+0.31%) ⬆️
ballerina/fragment_validator_visitor.bal 94.00% <100.00%> (+0.38%) ⬆️
ballerina/variable_validator_visitor.bal 97.82% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
@ThisaruGuruge ThisaruGuruge merged commit f0ba83d into ballerina-platform:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one kind of errors return from a invalid graphql request
2 participants