Fix Escape Character Issues #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisaruGuruge
requested review from
shafreenAnfar and
DimuthuMadushan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 59 59
Lines 4379 4379
Branches 2377 2377
=======================================
Hits 3794 3794
Misses 543 543
Partials 42 42
Continue to review full report at Codecov.
|
ayeshLK
reviewed
Jul 18, 2022
...ugin/src/main/java/io/ballerina/stdlib/graphql/compiler/schema/generator/GeneratorUtils.java
Outdated
Show resolved
Hide resolved
...ugin/src/main/java/io/ballerina/stdlib/graphql/compiler/schema/generator/GeneratorUtils.java
Outdated
Show resolved
Hide resolved
DimuthuMadushan
approved these changes
Jul 18, 2022
ThisaruGuruge
commented
Jul 18, 2022
Co-authored-by: DimuthuMadushan <35717653+DimuthuMadushan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a field name, argument name, or type name has escape characters, the generated schema causes problems. This PR will fix those issues.
Fixes: #3069
Fixes: #3067
Examples
Checklist