Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Service Crashing when Returning Nullable, Union Type Arrays #565

Conversation

DimuthuMadushan
Copy link
Contributor

@DimuthuMadushan DimuthuMadushan commented Jan 13, 2022

Purpose

Fixes: #2571
Fixes: #2578

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #565 (78ee73a) into master (0d463c7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #565      +/-   ##
============================================
+ Coverage     93.84%   93.88%   +0.03%     
- Complexity      346      352       +6     
============================================
  Files            53       53              
  Lines          3689     3712      +23     
  Branches       1962     1968       +6     
============================================
+ Hits           3462     3485      +23     
  Misses          199      199              
  Partials         28       28              
Impacted Files Coverage Δ
ballerina/response_formatter.bal 97.29% <100.00%> (+0.93%) ⬆️
...ina/stdlib/graphql/runtime/engine/EngineUtils.java 98.55% <100.00%> (+0.08%) ⬆️
...dlib/graphql/runtime/engine/ResponseGenerator.java 95.80% <100.00%> (+0.56%) ⬆️
ballerina/engine.bal 96.96% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d463c7...78ee73a. Read the comment docs.

@DimuthuMadushan DimuthuMadushan force-pushed the fix-typename-introspection branch from 7a89708 to 78ee73a Compare January 13, 2022 07:35
@shafreenAnfar shafreenAnfar merged commit a5a5580 into ballerina-platform:master Jan 13, 2022
@DimuthuMadushan DimuthuMadushan deleted the fix-typename-introspection branch September 30, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants