Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Result Coercion to Comply with the Spec #446

Merged
merged 15 commits into from
Oct 14, 2021

Conversation

ThisaruGuruge
Copy link
Member

@ThisaruGuruge ThisaruGuruge commented Oct 13, 2021

Purpose

$Subject

Fixes: #1988
Fixes: #2041
Fixes: #2042

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #446 (b4a3ce1) into master (7eacc7f) will increase coverage by 0.11%.
The diff coverage is 96.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #446      +/-   ##
============================================
+ Coverage     94.51%   94.63%   +0.11%     
- Complexity      286      287       +1     
============================================
  Files            50       50              
  Lines          2788     2831      +43     
  Branches       1338     1360      +22     
============================================
+ Hits           2635     2679      +44     
+ Misses          132      131       -1     
  Partials         21       21              
Impacted Files Coverage Δ
ballerina/executor_visitor.bal 90.69% <ø> (ø)
ballerina/records.bal 73.68% <ø> (ø)
ballerina/response_formatter.bal 95.41% <95.41%> (ø)
ballerina/common_utils.bal 95.89% <100.00%> (+0.11%) ⬆️
ballerina/engine.bal 98.41% <100.00%> (ø)
...dlib/graphql/runtime/engine/ResponseGenerator.java 99.09% <100.00%> (+<0.01%) ⬆️
...ina/stdlib/graphql/runtime/schema/FieldFinder.java 98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eacc7f...b4a3ce1. Read the comment docs.

@shafreenAnfar
Copy link
Contributor

LGTM

@ThisaruGuruge ThisaruGuruge merged commit d18bf3b into master Oct 14, 2021
@ThisaruGuruge ThisaruGuruge deleted the null-value-support branch October 14, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants