Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP Service Inside the GraphQL Listener an Isolated Object #243

Merged
merged 5 commits into from
May 22, 2021

Conversation

ThisaruGuruge
Copy link
Member

@ThisaruGuruge ThisaruGuruge commented May 21, 2021

Purpose

This PR will make the HttpService object in GraphQL listener an isolated object. This will enable the HTTP service to run parallelly.

Fixes: #1386

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #243 (ca67810) into master (2dd95b0) will increase coverage by 0.66%.
The diff coverage is 94.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
+ Coverage     90.99%   91.66%   +0.66%     
- Complexity      213      215       +2     
============================================
  Files            44       44              
  Lines          1822     1835      +13     
  Branches        771      773       +2     
============================================
+ Hits           1658     1682      +24     
+ Misses          150      139      -11     
  Partials         14       14              
Impacted Files Coverage Δ Complexity Δ
graphql-ballerina/annotation_processor.bal 100.00% <ø> (ø) 0.00 <0.00> (ø)
graphql-ballerina/records.bal 72.22% <ø> (ø) 0.00 <0.00> (ø)
...ballerina/stdlib/graphql/runtime/schema/Utils.java 83.78% <ø> (-1.22%) 20.00 <0.00> (-1.00)
graphql-ballerina/engine.bal 84.78% <71.42%> (-4.35%) 0.00 <0.00> (ø)
graphql-ballerina/common_utils.bal 96.00% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/engine_utils.bal 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/executor_visitor.bal 91.42% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/http_service.bal 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/listener.bal 77.50% <100.00%> (+1.82%) 0.00 <0.00> (ø)
graphql-ballerina/validator_visitor.bal 89.04% <100.00%> (+0.20%) 0.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd95b0...ca67810. Read the comment docs.

@shafreenAnfar shafreenAnfar merged commit 89008f7 into master May 22, 2021
@ThisaruGuruge ThisaruGuruge deleted the isolation-fix branch May 31, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HTTP Service Class Isolated
2 participants