Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input parameter validation #192

Merged
merged 5 commits into from
May 4, 2021
Merged

Conversation

ThisaruGuruge
Copy link
Member

@ThisaruGuruge ThisaruGuruge commented May 4, 2021

Purpose

Fixing bugs in input parameter validation.

Fixes: #1251
Fixes: #1269
Fixes: #1266

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #192 (2a5243b) into master (6b3bc35) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
+ Coverage     89.13%   89.32%   +0.19%     
- Complexity      194      197       +3     
============================================
  Files            41       41              
  Lines          1703     1696       -7     
  Branches        686      693       +7     
============================================
- Hits           1518     1515       -3     
+ Misses          166      164       -2     
+ Partials         19       17       -2     
Impacted Files Coverage Δ Complexity Δ
graphql-ballerina/engine.bal 76.00% <ø> (-5.54%) 0.00 <0.00> (ø)
graphql-ballerina/records.bal 71.42% <ø> (ø) 0.00 <0.00> (ø)
graphql-ballerina/executor_visitor.bal 92.53% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/validator_visitor.bal 90.70% <100.00%> (+0.25%) 0.00 <0.00> (ø)
...allerina/stdlib/graphql/runtime/engine/Engine.java 90.74% <100.00%> (+0.54%) 13.00 <0.00> (+1.00)
...ina/stdlib/graphql/runtime/schema/FieldFinder.java 96.11% <100.00%> (+1.94%) 32.00 <0.00> (+1.00)
.../graphql/runtime/schema/SchemaRecordGenerator.java 100.00% <100.00%> (+2.66%) 26.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3bc35...2a5243b. Read the comment docs.

@ThisaruGuruge ThisaruGuruge force-pushed the input-parameter-validation branch from 580fc0f to 2a5243b Compare May 4, 2021 15:01
@shafreenAnfar shafreenAnfar merged commit 0cb6ba6 into master May 4, 2021
@ThisaruGuruge ThisaruGuruge deleted the input-parameter-validation branch May 4, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants