Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hanging the Service when Returning Array #178

Conversation

DimuthuMadushan
Copy link
Contributor

Purpose

Fixes: #1250

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
@ballerina-platform ballerina-platform deleted a comment from codecov bot Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #178 (fc6f32c) into master (d160352) will increase coverage by 0.01%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     89.73%   89.74%   +0.01%     
- Complexity      232      233       +1     
============================================
  Files            42       42              
  Lines          1821     1823       +2     
  Branches        699      700       +1     
============================================
+ Hits           1634     1636       +2     
  Misses          162      162              
  Partials         25       25              
Impacted Files Coverage Δ Complexity Δ
...b/graphql/runtime/engine/CallableUnitCallback.java 95.19% <92.85%> (+0.09%) 29.00 <0.00> (+1.00)
graphql-ballerina/engine_utils.bal 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
graphql-ballerina/executor_visitor.bal 92.53% <100.00%> (ø) 0.00 <0.00> (ø)
...allerina/stdlib/graphql/runtime/engine/Engine.java 92.30% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d160352...fc6f32c. Read the comment docs.

@ThisaruGuruge ThisaruGuruge merged commit d6e8af6 into ballerina-platform:master Apr 27, 2021
@DimuthuMadushan DimuthuMadushan deleted the fix-service-array-return branch September 30, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL service hangs when returning an array
2 participants