Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the Stream when a Subscription Operation is Completed #1067

Merged

Conversation

ThisaruGuruge
Copy link
Member

Purpose

$Subject

Fixes: #3661

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 87.14% // Head: 87.12% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (35a4a6f) compared to base (461dcc6).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   87.14%   87.12%   -0.03%     
==========================================
  Files          59       59              
  Lines        4498     4504       +6     
  Branches     2458     2463       +5     
==========================================
+ Hits         3920     3924       +4     
- Misses        548      550       +2     
  Partials       30       30              
Impacted Files Coverage Δ
ballerina/websocket_service.bal 85.36% <ø> (ø)
ballerina/websocket_utils.bal 95.65% <66.66%> (-2.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThisaruGuruge ThisaruGuruge merged commit 7a548aa into ballerina-platform:master Nov 16, 2022
@ThisaruGuruge ThisaruGuruge deleted the close-stream-fix branch November 16, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Subscriptions does not Close the Stream After it is Completed
2 participants