Improve callMethod logic #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinperera00
requested review from
NipunaRanasinghe,
ayeshLK,
Nuvindu and
shafreenAnfar
as code owners
| if (runtime != null) { | ||
| Set<Map.Entry<String, BObject>> services = registeredServices.entrySet(); | ||
| for (Map.Entry<String, BObject> service : services) { | ||
| runtime.callMethod(service.getValue(), ON_MESSAGE, new StrandMetadata(true, null), email); |
There was a problem hiding this comment.
We should check isolated logic here instead of passing true
There was a problem hiding this comment.
Fixed in 251aac9
ravinperera00
force-pushed
the
java21_sync
branch
2 times, most recently
from
4fc4e26 to
66edec9
Compare
ravinperera00
force-pushed
the
java21_sync
branch
from
66edec9 to
251aac9
Compare
warunalakshitha
approved these changes
Nov 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
============================================
- Coverage 80.90% 80.79% -0.11%
- Complexity 161 164 +3
============================================
Files 21 21
Lines 1021 1031 +10
Branches 166 167 +1
============================================
+ Hits 826 833 +7
- Misses 114 115 +1
- Partials 81 83 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Examples
Checklist