Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelise GraphQL document validation #3430

Closed
2 of 3 tasks
MohamedSabthar opened this issue Sep 28, 2022 · 1 comment · Fixed by ballerina-platform/module-ballerina-graphql#1081
Closed
2 of 3 tasks
Assignees
Labels
module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues Type/Improvement
Milestone

Comments

@MohamedSabthar
Copy link
Member

MohamedSabthar commented Sep 28, 2022

Description:
The current implementation of the graphql uses an array of visitors to validate the graphql document.

Tasks

  • Find the dependency between validator visitors (dependency graph)
  • Group the validators that can be executed in parallel by multiple workers
  • Check for performance improvement by comparing the load-test results

Describe your problem(s)
Each visitor is executed in sequence since the execution of some of these visitors depends on the previous visitor.

Describe your solution(s)
These visitors can be grouped by analysing the dependencies and executed parallelly to improve the performance.

Related Issues & PRs(optional):
#950

Suggested Labels (optional):

Suggested Assignees (optional):

@MohamedSabthar
Copy link
Member Author

Due to this intermittent failure, unable to compare the performance with the load test. Deprioritizing this task until issue #38047 gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues Type/Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants