Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled compiler exceptions being not result in test failures #34984

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

lochana-chathura
Copy link
Member

Purpose

$subject.

Fixes #34553

Approach

N/A

Samples

N/A

Remarks

N/A

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #34984 (498ed96) into 2201.0.x (6d1f4b4) will decrease coverage by 0.00%.
The diff coverage is 77.85%.

Impacted file tree graph

@@              Coverage Diff               @@
##             2201.0.x   #34984      +/-   ##
==============================================
- Coverage       74.11%   74.11%   -0.01%     
- Complexity      46418    46439      +21     
==============================================
  Files            3140     3140              
  Lines          181114   181150      +36     
  Branches        23386    23401      +15     
==============================================
+ Hits           134231   134253      +22     
- Misses          39084    39106      +22     
+ Partials         7799     7791       -8     
Impacted Files Coverage Δ
...main/java/io/ballerina/projects/ModuleContext.java 90.03% <0.00%> (-2.24%) ⬇️
...na/projects/internal/configschema/VisitedType.java 100.00% <ø> (ø)
.../providers/createvar/CreateVariableCodeAction.java 93.75% <0.00%> (+2.08%) ⬆️
...g/debugadapter/evaluation/utils/VariableUtils.java 56.14% <ø> (ø)
...lerinalang/debugadapter/JBallerinaDebugServer.java 71.92% <14.28%> (-0.97%) ⬇️
...debugadapter/evaluation/utils/EvaluationUtils.java 71.24% <50.00%> (ø)
...llerinalang/langserver/util/rename/RenameUtil.java 84.86% <68.42%> (+1.52%) ⬆️
...codeaction/providers/CreateFunctionCodeAction.java 82.22% <69.23%> (+3.84%) ⬆️
...and/visitors/FunctionCallExpressionTypeFinder.java 76.58% <77.77%> (+0.11%) ⬆️
...lerinalang/langserver/common/utils/CommonUtil.java 80.08% <80.00%> (+0.38%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3889401...498ed96. Read the comment docs.

@lochana-chathura lochana-chathura changed the base branch from ballerina-2.0.x to 2201.0.x February 21, 2022 05:20
hasithaa
hasithaa previously approved these changes Feb 28, 2022
@hasithaa
Copy link
Contributor

Shall we change the base to master?

@hasithaa hasithaa changed the base branch from 2201.0.x to master February 28, 2022 05:10
@hasithaa hasithaa dismissed their stale review February 28, 2022 05:10

The base branch was changed.

@pcnfernando pcnfernando merged commit 9d63d69 into ballerina-platform:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
No open projects
Archived in project
3 participants