-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unhandled compiler exceptions being not result in test failures #34984
Merged
pcnfernando
merged 2 commits into
ballerina-platform:master
from
lochana-chathura:fix-exception
Feb 28, 2022
Merged
Fix unhandled compiler exceptions being not result in test failures #34984
pcnfernando
merged 2 commits into
ballerina-platform:master
from
lochana-chathura:fix-exception
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2201.0.x #34984 +/- ##
==============================================
- Coverage 74.11% 74.11% -0.01%
- Complexity 46418 46439 +21
==============================================
Files 3140 3140
Lines 181114 181150 +36
Branches 23386 23401 +15
==============================================
+ Hits 134231 134253 +22
- Misses 39084 39106 +22
+ Partials 7799 7791 -8
Continue to review full report at Codecov.
|
pcnfernando
reviewed
Feb 10, 2022
compiler/ballerina-lang/src/main/java/io/ballerina/projects/ModuleContext.java
Show resolved
Hide resolved
…erina-lang into fix-exception
hasithaa
previously approved these changes
Feb 28, 2022
Shall we change the base to master? |
hasithaa
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes #34553
Approach
N/A
Samples
N/A
Remarks
N/A
Check List