Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the display label name of the http default listener #592

Merged

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

Screen.Recording.2025-02-11.at.17.03.38.mov

@NipunaRanasinghe
Copy link
Contributor

Screenshot 2025-02-11 at 17 12 59

Here do we need this whole Create and use the default HTTP listener text in the dropdown option? maybe we can just use something simpler like HTTP default listener, as what we are showing for the other listeners is just the name. @hasithaa wdyt?

@LakshanWeerasinghe
Copy link
Contributor Author

Screenshot 2025-02-11 at 17 12 59 Here do we need this whole `Create and use the default HTTP listener` text in the dropdown option? maybe we can just use something simpler like `HTTP default listener`, as what we are showing for the other listeners is just the name. @hasithaa wdyt?

Here our intention was to imply that it is an action we are going to perform. This one of the UI/UX design practices use when we have a drop down.

@NipunaRanasinghe
Copy link
Contributor

NipunaRanasinghe commented Feb 11, 2025

Screenshot 2025-02-11 at 17 12 59 Here do we need this whole `Create and use the default HTTP listener` text in the dropdown option? maybe we can just use something simpler like `HTTP default listener`, as what we are showing for the other listeners is just the name. @hasithaa wdyt?

Here our intention was to imply that it is an action we are going to perform. This one of the UI/UX design practices use when we have a drop down.

If I understand correctly, then we haven't followed the best possible design option for the dropdown. as shown below currently we have a +Listener option outside the dropdown, which is not recommended as per the above conventions right?
Screenshot 2025-02-11 at 17 31 45

@LakshanWeerasinghe
Copy link
Contributor Author

Screenshot 2025-02-11 at 17 12 59 Here do we need this whole `Create and use the default HTTP listener` text in the dropdown option? maybe we can just use something simpler like `HTTP default listener`, as what we are showing for the other listeners is just the name. @hasithaa wdyt?

Here our intention was to imply that it is an action we are going to perform. This one of the UI/UX design practices use when we have a drop down.

If I understand correctly, then we haven't followed the deisgn option for the dropdown. as shown below currently we have a +Listener option outside the dropdown, which is not recommended as per the above conventions right? Screenshot 2025-02-11 at 17 31 45

In that case we should goto a different form. But in the default listener case we don't need to goto a different form. Because of that we can add this "Create and use the HTTP listener" option to the item list.

@hasithaa
Copy link
Contributor

We came up with this design after multiple reviews. let's use this for now and get feedback to improve this further. Having multi-step listener creation is cleaner. But it complicates the creation process.

@hasithaa hasithaa merged commit 27152ba into ballerina-platform:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants