Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Visual C++ Fix, include the numberic std #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

N0CTRON
Copy link

@N0CTRON N0CTRON commented Aug 26, 2024

No description provided.

@baileyheading
Copy link
Contributor

with this change does windows run?

@balisujohn
Copy link
Owner

Here is a windows msvc draft that I did get to work at one point https://github.com/balisujohn/tortoise.cpp/tree/dev-windows, though it creates a DLL which has to manually be moved to the folder with the executable get the executable to run. It seems like the include strategy is in this PR better than the way I did it here, so I'll accept this PR over the change in my prototype. I have an internal draft which compiles with msvc which creates a self-contained executable with no DLLS, but if I recall correctly there were errors when running the executable, for the no DLL version.

@baileyheading
Copy link
Contributor

Sounds good! I'm going to have access to GeForce very soon (still using Mac though too) so I'll be keen to try out CUDA for windows soon. I would've commented on an issue but there isn't one for some reason :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants