Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This supports build for the NXP imx8mm-lpddr4-evk reference platform. #526

Closed
wants to merge 1 commit into from
Closed

This supports build for the NXP imx8mm-lpddr4-evk reference platform. #526

wants to merge 1 commit into from

Conversation

ajlennon
Copy link
Contributor

@ajlennon ajlennon commented Oct 4, 2023 •
edited
Loading

More work is needed to be able to take this out of DEVELOPMENT status

  • add Balena website details for this board at given links
  • "contracts" have not been looked at
  • check LED working
  • check HDMI working
  • writing to /dev/ttymxc0 seems to reset the board
  • need to check support for secure boot / secure filesystem
  • need to support image flasher
  • CI/CD testing
  • support WiFi module

Changelog-entry: Add support for NXP imx8mm-lpddr4-evk board

@ajlennon
Copy link
Contributor Author

ajlennon commented Oct 4, 2023

This is building, booting, and onboarding to the Balena cloud now. Could we review into upstream please?

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@alexgg
Copy link
Contributor

alexgg commented Oct 5, 2023

@ajlennon the flasher image is working already, is it not?

@ajlennon
Copy link
Contributor Author

ajlennon commented Oct 5, 2023

@ajlennon the flasher image is working already, is it not?

It was pending - working now in the latest commit to the PR

floion
floion requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@floion floion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe squash this with the first commit?

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from 3e54e2e to 590f011 Compare October 10, 2023 12:57
@ajlennon
Copy link
Contributor Author

ok I've squashed those @floion

@floion
Copy link
Contributor

floion commented Oct 11, 2023

Thanks @ajlennon this PR needs to be updated again. When you do it from the Github UI you can choose to update it with the rebase option, this makes the ugly merge commit go away.

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from 19d7b58 to d323690 Compare October 11, 2023 09:01
@ajlennon
Copy link
Contributor Author

Thanks @floion - OK just did that

@ajlennon
Copy link
Contributor Author

@floion do I need to do something else ?

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from d323690 to 49b300e Compare October 16, 2023 14:52
@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch 2 times, most recently from c844208 to e9a7195 Compare October 20, 2023 09:56
ajlennon
ajlennon commented Oct 20, 2023
View reviewed changes
Copy link
Contributor Author

@ajlennon ajlennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @floion with a bit of luck I've made all those changes requested now. Could you take a look please?

imx8mm-lpddr4-evk-nxp.coffee Outdated Show resolved Hide resolved
layers/meta-balena-fsl-arm/recipes-kernel/linux/linux-fslc-imx_%.bbappend Outdated Show resolved Hide resolved
layers/meta-balena-fsl-arm/recipes-kernel/linux/linux-fslc-imx_%.bbappend Outdated Show resolved Hide resolved
layers/meta-balena-fsl-arm/recipes-kernel/linux/linux-fslc-imx_%.bbappend Outdated Show resolved Hide resolved
@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch 3 times, most recently from c5ff997 to f51403c Compare October 22, 2023 10:19
@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch 3 times, most recently from 0bba5a0 to e51d2e3 Compare October 24, 2023 09:59
@floion floion enabled auto-merge October 25, 2023 07:12
auto-merge was automatically disabled October 25, 2023 13:37

Head branch was pushed to by a user without write access

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from e51d2e3 to 7b56dbb Compare October 25, 2023 13:37
@floion floion enabled auto-merge October 26, 2023 06:26
auto-merge was automatically disabled October 26, 2023 06:30

Head branch was pushed to by a user without write access

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch 3 times, most recently from 95ec78f to 4a6955a Compare October 26, 2023 06:31
@floion floion enabled auto-merge October 26, 2023 06:34
@floion
Copy link
Contributor

floion commented Oct 26, 2023

@balena-ci I self-certify!

auto-merge was automatically disabled October 27, 2023 08:36

Head branch was pushed to by a user without write access

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from 4a6955a to 1a7ffa3 Compare October 27, 2023 08:36
@floion floion enabled auto-merge October 27, 2023 09:04
@floion
Copy link
Contributor

floion commented Oct 27, 2023

@balena-ci I self-certify!

@ajlennon
Copy link
Contributor Author

ajlennon commented Nov 1, 2023

So can this be merged in now @floion or are we waiting for the AutoKit testing before merging?

@ajlennon
This supports build for the NXP imx8mm-lpddr4-evk reference platform.
c92cb2f 
More work is needed:
- add Balena website details for this board at given links
- "contracts" have not been looked at
- writing to /dev/ttymxc0 seems to reset the board
- need to check support for secure boot / secure filesystem
- need to support image flasher
- testing

Changelog-entry: Add support for NXP imx8mm-lpddr4-evk board
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Remove extraneous patch

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Default to balenaOS image flasher

We have made changes to correctly enable build of the
flasher image which has been tested to run up and flash
the onboard EVK eMMC part correctly. This then boots
and runs up to the BalenaOS prompt

TODO:

- Still need to verify portal HostOS update works
  but will do that when device is supported through
  portal

Changelog-entry: Default imx8mm-lpddr4-evk board to image-flasher
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

Use correct Yocto MACHINE name imx8mm-lpddr4-evk

I was overriding this to append -nxp to enable use of
IMX_DEFAULT_BSP="nxp" but am now adding this in layer.conf
instead so we can use the original machine name

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

iwlwifi: Add support for Intel iwlwifi devices

We're using an M.2 WiFi module AX210NGW which this change supports

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

linux-fslc-imx: Changes for peer review

- inherit kernel-balena not kernel-resin
- tidy up comments
- make settings board specific for disabling kernel versioning
  and kernel patches
- don't disable apparmour as this done elsewhere
- don't optimise for size as we set f/s size for EVK board

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

linux-fslc-imx: Add kernel configuration fragment

For missing modules. Here we add a misssing netfilter
pktfilter module which is present on e.g. RaspberryPi
BalenaOS

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>

balena-image-initramfs: Don't remove module-recovery for NXP EVK

From review, "This was removed from the other device type because of space constraints. You should not be impacted by that since you enlarged the rootfs so you should be able to have this module included in the initramfs"

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
auto-merge was automatically disabled November 2, 2023 14:00

Head branch was pushed to by a user without write access

@ajlennon ajlennon force-pushed the ajl/add-imx8mm-lpddr4-evk-support branch from 1a7ffa3 to c92cb2f Compare November 2, 2023 14:00
@floion floion enabled auto-merge November 3, 2023 07:45
@floion
Copy link
Contributor

floion commented Nov 10, 2023

Superseded by #551

@floion floion closed this Nov 10, 2023
auto-merge was automatically disabled November 10, 2023 08:03

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgg alexgg alexgg left review comments

@floion floion floion approved these changes

@acostach acostach Awaiting requested review from acostach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajlennon @resin-jenkins @alexgg @floion