odata/abstract-sql-compiler: Add support for specifying the model name for config files #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
force-pushed
the
select-model
branch
2 times, most recently
from
3c0b2a3 to
0ff3c6b
Compare
| export const getAbstractSqlModelFromFile = ( | ||
| modelFile: string, | ||
| modelName: string | undefined, |
There was a problem hiding this comment.
you probably need modelName?: string no?
There was a problem hiding this comment.
Apparently tests use this function which is why I didn't catch it (tests use a different tsconfig). I did intentionally make it required because for the cli use cases it should always be provided, but for tests it's a bit different - I think I'll make the tests bend to the better method for the real code
otaviojacobi
requested changes
Jun 26, 2024
…e for config files This allows choosing which model to use when the config file contains multiple models Change-type: minor
otaviojacobi
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows choosing which model to use when the config file contains multiple models
Change-type: minor