resin.models.device.ensureSupervisorCompatibility(): add tests and handle invalid semver versions gracefully #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
previously approved these changes
Sep 27, 2016
lekkas
force-pushed
the
222-handle-invalid-semver-versions-gracefully
branch
from
eaf160b
to
18e0d80
Compare
|
Tests fail with TIL that |
|
Yeah, I PRed #219 when I found out that :P |
|
If it wasn't for the warning I'd definitely have used my own account :P |
…ndle invalid semver versions gracefully
lekkas
force-pushed
the
222-handle-invalid-semver-versions-gracefully
branch
from
18e0d80
to
45438ab
Compare
kaisoz
added
the
versionbot/pr-draft
ghost
dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222