Standardize trim and filter of instructions

Change-type: patch Signed-off-by: Micah Halter <micah@balena.io>
balena-io · Oct 25, 2022 · b2f9e2b · b2f9e2b
1 parent dff5bdc
commit b2f9e2b
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/lib/models/device-type.ts b/lib/models/device-type.ts
@@ -402,17 +402,14 @@ const getDeviceTypeModel = function (deps: InjectedDependenciesParam) {
 					deviceType: interpolatedDeviceType,
 				});
 
+				let instructions: string[] = interpolatedHostOS.partials[installMethod];
 				if (baseInstructions) {
-					return Handlebars.compile(baseInstructions)({
+					instructions = Handlebars.compile(baseInstructions)({
 						...interpolatedHostOS,
-						instructions: interpolatedHostOS.partials[installMethod],
-					})
-						.split('\n')
-						.map((s) => s.trim())
-						.filter((s) => s);
-				} else {
-					return interpolatedHostOS.partials[installMethod];
+						instructions,
+					}).split('\n');
 				}
+				return instructions.map((s) => s.trim()).filter((s) => s);
 			} else {
 				return [];
 			}