-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm-shrinkwrap.json to control dependency updates #1326
Conversation
@@ -167,7 +167,7 @@ | |||
"mixpanel": "^0.10.1", | |||
"mkdirp": "^0.5.1", | |||
"moment": "^2.24.0", | |||
"moment-duration-format": "~2.2.2", | |||
"moment-duration-format": "^2.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that 2.3 broke the typings but for sure we now don't have any reason to not change it to a ^
.
After all, whoever tries to change the shrinkwrap will see whether it breaks the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about the typings, but I knew about 2 issues that I raised myself in the upstream repo:
... which had broken balena CLI and required us to pin it to ~2.2.2
. Upstream claims to have fixed it but I have not tested it myself. I was careful to add npm-shrinkwrap.json
in a separate previous commit to the unpinning, so the CLI should still use moment-duration-format
v2.2.2 anyway.
@balena-ci retest |
c3c87d6
to
65512bc
Compare
@@ -1 +0,0 @@ | |||
package-lock=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found that package-lock=false
also disables npm-shrinkwrap.json
, hence deleting this line and the resulting blank file.
It seems that we will have to cut a release for https://github.com/balena-io-modules/node-web-streams as |
Change-type: patch Signed-off-by: Paulo Castro <paulo@balena.io>
Change-type: patch Signed-off-by: Paulo Castro <paulo@balena.io>
65512bc
to
77089e3
Compare
@thgreasi, although I couldn't reproduce the issue on Friday as in the Flowdock discussion, I think there was indeed a problem that even affected users: see issues #1331 and #1332. Please review pull request #1334 that hopefully fixes the issue. |
Resolves: #1293
Change-type: patch