Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm-shrinkwrap.json to control dependency updates #1326

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

pdcastro
Copy link
Contributor

Resolves: #1293
Change-type: patch

@@ -167,7 +167,7 @@
"mixpanel": "^0.10.1",
"mkdirp": "^0.5.1",
"moment": "^2.24.0",
"moment-duration-format": "~2.2.2",
"moment-duration-format": "^2.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that 2.3 broke the typings but for sure we now don't have any reason to not change it to a ^.
After all, whoever tries to change the shrinkwrap will see whether it breaks the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about the typings, but I knew about 2 issues that I raised myself in the upstream repo:

... which had broken balena CLI and required us to pin it to ~2.2.2. Upstream claims to have fixed it but I have not tested it myself. I was careful to add npm-shrinkwrap.json in a separate previous commit to the unpinning, so the CLI should still use moment-duration-format v2.2.2 anyway.

@pdcastro
Copy link
Contributor Author

@balena-ci retest

@pdcastro pdcastro marked this pull request as ready for review June 27, 2019 00:50
@pdcastro pdcastro requested review from zvin and dfunckt June 27, 2019 00:50
@pdcastro pdcastro force-pushed the 1293-add-npm-shrinkwrap branch from c3c87d6 to 65512bc Compare June 27, 2019 02:02
@pdcastro pdcastro requested a review from Page- June 27, 2019 02:23
@@ -1 +0,0 @@
package-lock=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found that package-lock=false also disables npm-shrinkwrap.json, hence deleting this line and the resulting blank file.

@thgreasi
Copy link
Member

It seems that we will have to cut a release for https://github.com/balena-io-modules/node-web-streams as @balena/node-web-streams and update the respective line in balena request (we did something like this before for grid-styled).
See: https://github.com/balena-io-modules/balena-request/blob/4f33d99336a0c697d25980aa3132cd2de18bbc65/package.json#L59

pdcastro added 2 commits June 28, 2019 12:29
Change-type: patch
Signed-off-by: Paulo Castro <paulo@balena.io>
Change-type: patch
Signed-off-by: Paulo Castro <paulo@balena.io>
@pdcastro pdcastro force-pushed the 1293-add-npm-shrinkwrap branch from 65512bc to 77089e3 Compare June 28, 2019 12:48
@pdcastro pdcastro merged commit a6b2825 into master Jun 28, 2019
@pdcastro
Copy link
Contributor Author

pdcastro commented Jul 1, 2019

It seems that we will have to cut a release for https://github.com/balena-io-modules/node-web-streams as @balena/node-web-streams

@thgreasi, although I couldn't reproduce the issue on Friday as in the Flowdock discussion, I think there was indeed a problem that even affected users: see issues #1331 and #1332. Please review pull request #1334 that hopefully fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit a 'npm-shrinkwrap.json' file to control dependency updates
4 participants