Optimize docker requests for local builds #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some optimizations for requests going over the docker socket during local builds.
cachefrom
from the options passed to thepull
operation, as there is evidence to suggest that the cache option getting too big would be the cause of builds terminating without error on Suggestion: Make it accept the API key when it's in the C&P buffer balena-io/balena-cli#216. Thecachefrom
option is not used by Docker's ImageCreate endpoint, so removing should have no side effects.Change-type: patch