Optimize docker requests for local builds #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes unnecessary queries to the registry for intermediate stage images in the dockerfile. Querying the registry for these images would fail in the best case or could cause false positives in the worst case. This commit adds an additional filter during parsing of the dockerfile to remove any intermediate stages from the query list. Change-type: patch
This option is not used by the [Docker API](https://docs.docker.com/engine/api/v1.43/#tag/Image/operation/ImageCreate). As the cache can get really big, depending on how the cache list is obtained, this may mean sending a huge query string over the local network. There is good evidence to suggest that this could be the cause of balena-io/balena-cli#2165, which would cause the query string to over the 1MB limit set by [Golang's net/http server](https://pkg.go.dev/net/http#Server). Change-type: patch
pipex
changed the title
|
I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some optimizations for requests going over the docker socket during local builds.
cachefromfrom the options passed to thepulloperation, as there is evidence to suggest that the cache option getting too big would be the cause of builds terminating without error on Suggestion: Make it accept the API key when it's in the C&P buffer balena-io/balena-cli#216. Thecachefromoption is not used by Docker's ImageCreate endpoint, so removing should have no side effects.Change-type: patch