Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opponent rage-quitting is named "Loss" #14

Open
derfectu opened this issue Aug 10, 2020 · 1 comment · May be fixed by #18
Open

Opponent rage-quitting is named "Loss" #14

derfectu opened this issue Aug 10, 2020 · 1 comment · May be fixed by #18
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@derfectu
Copy link

An example:

https://ballchasing.com/replay/9c56f231-72e8-4db8-8389-e265cf0c25c2

The score is 2 - 2 my opponent left before I scored the winning goal and the name of the replay is:

2020-08-10.19.41 derfectu Casual Duel Loss
@Bakkes
Copy link
Member

Bakkes commented Aug 20, 2020

Looks like

AutoReplayUploader/Uploader/Player.cpp

Line 13 in 71a2fdf

return Team == 0 ? team0Score > team1Score : team1Score > team0Score;
needs to actually return the match winner instead of doing a simple score check

@Bakkes Bakkes added bug Something isn't working good first issue Good for newcomers labels Aug 20, 2020
Bakkes added a commit that referenced this issue Aug 20, 2020
@Bakkes
Correctly set winning team
8bb2455 
Gets rid of simple score check which could be equal. Checks game match winner instead (fixes #14)
@Bakkes Bakkes linked a pull request Aug 20, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly set winning team bakkesmodorg/AutoReplayUploader
2 participants
@Bakkes @derfectu