Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various features #273

Merged
merged 14 commits into from
Oct 3, 2023
Merged

Various features #273

merged 14 commits into from
Oct 3, 2023

Conversation

ShadowMikado
Copy link
Contributor

I have done all of the following:

  • Added the feature.
  • Added documentation for the feature.
  • Added tests for the feature.
  • Ran mypy, black, and unit tests.

DOCUMENTATION

I have added one new feature:

get_calendar: allows retrieving a unique URL for a PRONOTE user's calendar. Returns a unique url to access the user's calendar (I don't know if this is available for other PRONOTE systems edited: Working), combined with client.pronote_url to retrieve the full unique URL.

last_connection in Clientinfo, allows getting the last connection date, returns datetime.datetime

@bain3
Copy link
Owner

bain3 commented Oct 3, 2023

Hi, thanks for the PR! I've renamed the get_calendar property, because it was a little confusing (we already have an export_ical), and added some parameters to it to customize the PDF generation.

I've also moved the last_connection property to Client and made it an attribute instead, since it isn't anything computationally heavy.

I hope that's alright.

@bain3 bain3 merged commit 3f11d73 into bain3:master Oct 3, 2023
@bain3 bain3 mentioned this pull request Nov 18, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants