Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一些小的代码优化 #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

xwarrior
Copy link

@xwarrior xwarrior commented Jun 7, 2016

除了1.8版本java外,其它修改对于项目没有任何副作用,主要是一些性能多线程,基本对象unboxin方面的优化。

@dsfan
Copy link
Collaborator

dsfan commented Jun 15, 2016

@xwarrior 谢谢提交。考虑到你修改的内容某些地方不是特别合适,建议你继续修改一下,如下:
1、 “升级到java1.8” 这个不要修改,我们基于java1.6开发是为了保证更多的用户能够方便的使用,用户如果有需要,自行调整版本
2、“增加double locking检查” 这里的修改其实都在同步块内,所以double locking也是没必要的
3、其他地方的修改没什么问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants