Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise an exception if saving failed #11

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

qix
Copy link
Contributor

@qix qix commented Aug 23, 2016

I don't believe not writing the cache should fail silently; but it also shouldn't raise an exception which was causing test failures for us.

@bahmutov bahmutov merged commit 22691a6 into bahmutov:master Aug 23, 2016
@bahmutov
Copy link
Owner

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants