Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Booking -> We should not be selecting dates of tickets outside the Event Date. #49

Closed
ashishkumar-webkul opened this issue Mar 6, 2024 · 3 comments
Assignees

Comments

@ashishkumar-webkul
Copy link
Collaborator

Issue Description

When we are creating a Event Boooking Product and there we have selected the dates of booking and when we add Tickets and there we are selecting the tickets dates after the Event is expired. We are able to save the date and also save the product.

Preconditions

  1. Admin must be logged in.

Steps to reproduce

  1. Go to Admin End -> Catalog -> Products -> Create a Event Booking Product.
  2. After Event Date selection -> Add Ticket -> Now select the date outside the Event.
  3. Save the product.

Expected Result

We should not be able to select the dates of tickets after the event are closed.

Actual Result

Event Booking Tickets dates are selected after the event is getting expired.

Video

Date.selected.outside.mp4
@ashishkumar-webkul ashishkumar-webkul added the Bug Something isn't working label Mar 6, 2024
amit-webkul added a commit to amit-webkul/booking-product that referenced this issue Mar 8, 2024
@amit-webkul amit-webkul added Fix proposed and removed Bug Something isn't working labels Mar 8, 2024
@ashishkumar-webkul
Copy link
Collaborator Author

Checked and found that the issue is not fixed. We are still able to save the tickets after the event is expired.

Video

Checkedxd.mp4

@amit-webkul
Copy link
Collaborator

@ashishkumar-webkul sir ,
The outside date of the tickets is related to the ticket, and the inside date of the ticket is related to the ticket special price.
Both are different.

@ashishkumar-webkul
Copy link
Collaborator Author

As per the discussion with Amit it was found that the time frame selected in ticket is of the Special Price, Hence this issue is not valid. And Marking this issue as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants