Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN should map to -Inf for maximizer #71

Merged
merged 5 commits into from
Feb 10, 2022
Merged

NaN should map to -Inf for maximizer #71

merged 5 commits into from
Feb 10, 2022

Conversation

albheim
Copy link
Contributor

@albheim albheim commented Feb 10, 2022

I feel like this makes more sense, otherwise the NaN value will always be picked for maximizers?

@baggepinnen baggepinnen merged commit bf901f3 into baggepinnen:master Feb 10, 2022
@baggepinnen
Copy link
Owner

Tackar :)

@albheim albheim deleted the fixnan branch February 11, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baggepinnen baggepinnen baggepinnen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albheim @baggepinnen