Fix parallel execution bug (issue #38) #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) Sorry it took me long to merge, it managed to get lost among my notifications :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the parallel execution bug in #38. That issue was caused because the samplers would tend to infer the iteration number as
iter = length(ho.history)+1, but the workers would not updateho.history, and so the iteration number would always be 1 on the workers. This would cause the sampler to re-initialize at every iteration.The work-around in this PR is to pass the iteration number to the samplers. I haven't done extensive testing, but this appears to work. There is one test case (GP sampler) that fails, but it fails for me on master too.