Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DB_HOST to POSTGRES_HOST #48

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Change DB_HOST to POSTGRES_HOST #48

merged 1 commit into from
Jan 5, 2025

Conversation

edwinm
Copy link
Collaborator

@edwinm edwinm commented Jan 4, 2025

Very small fix, but took me some time to figure out why the API stopped working. Better to be consistent and use POSTGRES_ for all Postgres env variables.

Make sure to set your .env file

POSTGRES_HOST= db

@edwinm edwinm requested a review from francisduvivier January 4, 2025 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 34.14% 790 / 2314
🔵 Statements 34.14% 790 / 2314
🔵 Functions 35.87% 47 / 131
🔵 Branches 83.05% 49 / 59
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/config.ts 100% 100% 100% 100%
Generated in workflow #96 for commit a9cd201 by the Vitest Coverage Report Action

@edwinm edwinm merged commit 68b52da into main Jan 5, 2025
3 checks passed
@edwinm edwinm deleted the fix/postgres-host branch January 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisduvivier francisduvivier Awaiting requested review from francisduvivier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edwinm