Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a bit of border to select boxes #9348

Merged
merged 3 commits into from
Jul 3, 2023
Merged

add a bit of border to select boxes #9348

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7c3cf6
add a bit of border to select boxes
chris48s Jul 3, 2023
fb47a1e
Merge branch 'master' into select-border
repo-ranger[bot] Jul 3, 2023
5727f71
Merge branch 'master' into select-border
repo-ranger[bot] Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ html[data-theme="dark"] .docusaurus-highlight-code-line {
color-scheme: initial;
}

input[type="text"] {
input[type="text"], :not(#fakeID#fakeId#fakeID) select {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not great CSS. Every select box has a couple of classes attached to it with long auto-generated names that I don't really want to use directly. They seem like they may not be reliable over time.
In order to make a more specific selector, I've used this hack https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity#increasing_specificity_by_duplicating_selector

I might have a look at opening a PR to implement this and #9324 upstream at the component layer so we clean this up a bit.

border-color: var(--ifm-color-primary-lightest);
border-style: solid;
border-width: 1px;
Expand Down