Go back to got #7175
Merged
Go back to got #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b209f5c.
|
| @@ -83,7 +83,7 @@ export default class SecurityHeaders extends BaseService { | |||
| }, | |||
| }) | |||
|
|
|||
| const grade = res.headers.get('x-grade') | |||
| const grade = res.headers['x-grade'] | |||
There was a problem hiding this comment.
ah, see you already ran into the same thing i encountered, sorry i hadn't noticed this before
calebcartwright
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having tried out a couple of different HTTP clients with a real workload, we've reached a conclusion: Go back to got and double down on it to replace request throughout the codebase.
closes #7123
closes #7124
closes #7167
closes #7168